[haskell-llvm] Int instead of CInt in FFI
Nathan Howell
nathan.d.howell at gmail.com
Wed May 15 17:38:12 BST 2013
It's very likely the patch would be accepted. Instead we're going to spend
more time waiting on an email exchange. But if you'd rather not send a pull
request that's perfectly fine too.
On Wed, May 15, 2013 at 9:32 AM, Henning Thielemann <
lemming at henning-thielemann.de> wrote:
>
> On Wed, 15 May 2013, Nathan Howell wrote:
>
> Sending a pull request would help get it fixed properly sooner and
>> they're great for discussing prior
>> patches in context. If there is a good reason to use e.g. Int instead of
>> CInt the pull request can be closed
>> without merging.
>>
>
> Sorry, I do not like to go all the trouble of creating a patch and making
> a pull request, just in order to get to know that it will be rejected. Can
> we please discuss before creating a patch?
>
> I have looked into git annotations and it seems that the change was
> introduced by commit 61820447235bde880b679a38e09d49**0dbd9dd8d9 by Nick
> Frolov. Thus I can direct my question to the author of the commit: Why do
> you think that Int is better than CInt for LLVMCmpInstGetPredicate?
> (However, there are more functions with Int instead of CInt by other
> authors.)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://projects.haskell.org/pipermail/haskell-llvm/attachments/20130515/842ad47a/attachment-0001.htm>
More information about the Haskell-llvm
mailing list