darcs patch: Generalise the type of showDigits. (and 2 more)

Jose A. Ortega Ruiz jao at gnu.org
Wed Dec 8 17:15:13 EST 2010


On Wed, Dec 08 2010, Petr Rockai wrote:

> "Jose A. Ortega Ruiz" <jao at gnu.org> writes:
>
>> we should left those to the template.
> Indeed, although it wasn't clear to me how to do that
> "right". Presumably you know how that should be done: hopefully, my new
> code shouldn't be hard to change to do that.

I've added Battery-specific arguments controlling how those fields are
printed. And no, it wasn't hard: your code was excellent.

>> I've moved xmobar's source to git (http://github.com/jaor/xmobar), and
>> the git repo is a bit ahead of the old darcs one, but i think i'll have
>> little problem in adapting your patches (unless you prefer to do that
>> yourself, which would be great :)). Once that's done, i will try them
>> and, eventually, make them official in a new release.
>
> Please do adapt them, I have no desire to learn git... I'll stick with
> releases for now.

Fair enough. Your patches (with some modifications of my own) are in
now.

As an aside, you don't need to learn git to use the latest sources: just
go to https://github.com/jaor/xmobar and click the "Downloads" button to
get a snapshot (of course, that's not as convenient as a darcs pull, but
just in case).

Needless to say, feel free to submit patches in any format and against
any repo: i'll take care of adapting them to the git repo.

Thanks again,
jao
-- 
In this world, there are only two tragedies.  One is not getting
what one wants, and the other is getting it. - Oscar Wilde



More information about the Xmobar mailing list